From: Al Viro Date: Wed, 26 Apr 2006 06:26:09 +0000 (+0100) Subject: [PATCH] forgotten ->b_data in memcpy() call in ext3/resize.c (oopsable) X-Git-Tag: v2.6.17-rc3~8 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=de0bb97aff6743f71abb8ec581238e2bdae9cdd1;p=pandora-kernel.git [PATCH] forgotten ->b_data in memcpy() call in ext3/resize.c (oopsable) sbi->s_group_desc is an array of pointers to buffer_head. memcpy() of buffer size from address of buffer_head is a bad idea - it will generate junk in any case, may oops if buffer_head is close to the end of slab page and next page is not mapped and isn't what was intended there. IOW, ->b_data is missing in that call. Fortunately, result doesn't go into the primary on-disk data structures, so only backup ones get crap written to them; that had allowed this bug to remain unnoticed until now. Signed-off-by: Al Viro Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed