From: Guenter Roeck Date: Thu, 12 Mar 2015 13:58:26 +0000 (-0400) Subject: sysfs: Use only return value from is_visible for the file mode X-Git-Tag: omap-for-v4.1/fixes-rc1~166^2~31 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=da4759c73b0f1aac79f37bdb39ad2124439c30e7;p=pandora-kernel.git sysfs: Use only return value from is_visible for the file mode Up to now, is_visible can only be used to either remove visibility of a file entirely or to add permissions, but not to reduce permissions. This makes it impossible, for example, to use DEVICE_ATTR_RW to define file attributes and reduce permissions to read-only. This behavior is undesirable and unnecessarily complicates code which needs to reduce permissions; instead of just returning the desired permissions, it has to ensure that the permissions in the attribute variable declaration only reflect the minimal permissions ever needed. Change semantics of is_visible to only use the permissions returned from it instead of oring the returned value with the hard-coded permissions. Signed-off-by: Guenter Roeck Signed-off-by: Vivien Didelot Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed