From: Paolo 'Blaisorblade' Giarrusso Date: Fri, 20 Oct 2006 06:28:24 +0000 (-0700) Subject: [PATCH] uml: cleanup run_helper() API to fix a leak X-Git-Tag: v2.6.19-rc3~108 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d9d645f06a8f50659bbae2be64ed8367ba068fc0;p=pandora-kernel.git [PATCH] uml: cleanup run_helper() API to fix a leak Freeing the stack is left uselessly to the caller of run_helper in some cases - this is taken from run_helper_thread, but here it is useless, so no caller needs it and the only place where this happens has a potential leak - in case of error neither run_helper() nor xterm_open() call free_stack(). At this point passing a pointer is not needed - the stack pointer should be passed directly, but this change is not done here. Signed-off-by: Paolo 'Blaisorblade' Giarrusso Cc: Jeff Dike Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed