From: Krzysztof Helt Date: Fri, 11 Jan 2008 20:50:46 +0000 (+0100) Subject: [SCSI] sym53c8xx: fixes two bugs related to chip reset X-Git-Tag: v2.6.25-rc1~1230^2~47 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d9aa3af09cdc5d3ae0e67bed4107bcf7e25b9f31;p=pandora-kernel.git [SCSI] sym53c8xx: fixes two bugs related to chip reset This patch fixes two bugs pointed by James Bottomley: 1. the if (!sym_data->io_reset). That variable is only ever filled by a stack based completion. If we find it non empty it means this code has been entered twice and we have a severe problem, so that should just become a BUG_ON(sym_data->io_reset). 2. sym_data->io_reset should be set to NULL before the routine is exited otherwise the PCI recovery code could end up completing what will be a bogus pointer into the stack. Big thanks to James Bottomley for help with the patch. Signed-off-by: Krzysztof Helt Signed-off-by: James Bottomley --- Reading git-diff-tree failed