From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
Date: Wed, 13 Feb 2008 07:10:11 +0000 (-0800)
Subject: [NET]: Fix race in dev_close(). (Bug 9750)
X-Git-Tag: v2.6.25-rc2~2^2~11
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d8b2a4d21e0b37b9669b202867bfef19f68f786a;p=pandora-kernel.git

[NET]: Fix race in dev_close(). (Bug 9750)

There is a race in Linux kernel file net/core/dev.c, function dev_close.
The function calls function dev_deactivate, which calls function
dev_watchdog_down that deletes the watchdog timer. However, after that, a
driver can call netif_carrier_ok, which calls function
__netdev_watchdog_up that can add the watchdog timer again. Function
unregister_netdevice calls function dev_shutdown that traps the bug
!timer_pending(&dev->watchdog_timer). Moving dev_deactivate after
netif_running() has been cleared prevents function netif_carrier_on
from calling __netdev_watchdog_up and adding the watchdog timer again.

Signed-off-by: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

Reading git-diff-tree failed