From: Oleg Drokin <green@linuxhacker.ru>
Date: Fri, 11 Mar 2011 01:17:27 +0000 (+0300)
Subject: firewire: ohci: Misleading kfree in ohci.c::pci_probe/remove
X-Git-Tag: v2.6.39-rc1~400^2~3
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d838d2c09af0820e306e3e9e31f97e873823b0b4;p=pandora-kernel.git

firewire: ohci: Misleading kfree in ohci.c::pci_probe/remove

It seems drivers/firewire/ohci.c is making some optimistic assumptions
about struct fw_ohci and that member "card" will always remain the first
member of the struct.
Plus it's probably going to confuse a lot of static code analyzers too.

So I wonder if there is a good reason not to free the ohci struct just
like it was allocated instead of the tricky &ohci->card way?

Signed-off-by: Oleg Drokin <green@linuxhacker.ru>

It is perhaps just a rudiment from before mainline submission of the
driver.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---

Reading git-diff-tree failed