From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Date: Tue, 23 Aug 2022 08:25:25 +0000 (+0200)
Subject: boot: fix vbe_find_first_device()
X-Git-Tag: v2022.10-rc4~9^2~8
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d81eeacd48f760516abf12e69aba4ce5dd44545f;p=pandora-u-boot.git

boot: fix vbe_find_first_device()

uclass_find_first_device() may return NULL if no device for the uclass
exists. Handle this case gracefully.

Addresses-Coverity: CID 356244 ("Null pointer dereferences (FORWARD_NULL)")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

diff --git a/boot/vbe.c b/boot/vbe.c
index e6ee087dc24..52b32830037 100644
--- a/boot/vbe.c
+++ b/boot/vbe.c
@@ -40,7 +40,7 @@ int vbe_find_next_device(struct udevice **devp)
 int vbe_find_first_device(struct udevice **devp)
 {
 	uclass_find_first_device(UCLASS_BOOTMETH, devp);
-	if (*devp && is_vbe(*devp))
+	if (!*devp || is_vbe(*devp))
 		return 0;
 
 	return vbe_find_next_device(devp);