From: Emmanuel Grumbach Date: Sun, 14 Apr 2013 11:41:03 +0000 (+0300) Subject: iwlwifi: mvm: fix first_antenna X-Git-Tag: omap-for-v3.10/dt-fixes-for-merge-window~77^2~18^2^2~8^2~7 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d7dad550e6ddb96db9d3e4d322f7d1dd8a6a9c8d;p=pandora-kernel.git iwlwifi: mvm: fix first_antenna first_antenna is supposed to return the first antenna as a 0-based bitmap: ANT_A is BIT(0), ANT_B is BIT(1), etc... Since ffs is 1 based (ffs(BIT(0)) = 1), then we had an off-by-one bug: BIT(ffs(ANT_A)) = BIT(ffs(BIT(0))) = BIT(1) = ANT_B. So what we really want is: BIT(ffs(ANT_A) - 1) = BIT(ffs(BIT(0)) - 1) = BIT(0) = ANT_A. Signed-off-by: Emmanuel Grumbach Signed-off-by: Johannes Berg --- Reading git-diff-tree failed