From: Laurent Pinchart Date: Tue, 17 Mar 2015 22:21:32 +0000 (+0200) Subject: of/irq: Fix of_irq_parse_one() returned error codes X-Git-Tag: omap-for-v4.1/fixes-rc1~290^2~3 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d7c146053dd195b90c79b9b8131431f44541d015;p=pandora-kernel.git of/irq: Fix of_irq_parse_one() returned error codes The error code paths that require cleanup use a goto to jump to the cleanup code and return an error code. However, the error code variable res, which is initialized to -EINVAL when declared, is then overwritten with the return value of of_parse_phandle_with_args(), and reused as the return code from of_irq_parse_one(). This leads to an undetermined error being returned instead of the expected -EINVAL value. Fix it. Signed-off-by: Laurent Pinchart Cc: stable@vger.kernel.org # 3.13+ Signed-off-by: Rob Herring --- Reading git-diff-tree failed