From: Daniel Ritz Date: Tue, 27 Jun 2006 16:40:54 +0000 (+0200) Subject: [PATCH] i2c-i801.c: don't pci_disable_device() after it was just enabled X-Git-Tag: v2.6.18-rc1~462 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d6fcb3b9cf776e3f748709cd3091a72cb3855c29;p=pandora-kernel.git [PATCH] i2c-i801.c: don't pci_disable_device() after it was just enabled Commit 02dd7ae2892e5ceff111d032769c78d3377df970 ("[PATCH] i2c-i801: Merge setup function") has a missing return 0 in the _probe() function. This means the error path is always executed and pci_disable_device() is called even when the device just got successfully enabled. Having the SMBus device disabled makes some systems (eg. Fujitsu-Siemens Lifebook E8010) hang hard during power-off. Intead of reverting the whole commit this patch fixes it up: - don't ever call pci_disable_device(), also not in the _remove() function to avoid hangs - fix missing pci_release_region() in error path Signed-off-by: Daniel Ritz Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed