From: Julia Lawall <julia@diku.dk>
Date: Sat, 6 Feb 2010 08:45:15 +0000 (+0000)
Subject: fs/xfs: Correct NULL test
X-Git-Tag: v2.6.34-rc1~278^2~1
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d67b1b03254c501fef371b0e5916c94a52bfc2c5;p=pandora-kernel.git

fs/xfs: Correct NULL test

Test the value that was just allocated rather than the previously tested one.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
expression *x;
expression e;
identifier l;
@@

if (x == NULL || ...) {
    ... when forall
    return ...; }
... when != goto l;
    when != x = e
    when != &x
*x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
---

Reading git-diff-tree failed