From: Richard Weinberger Date: Thu, 2 Oct 2014 13:00:35 +0000 (+0200) Subject: UBI: Fastmap: Fix races in ubi_wl_get_peb() X-Git-Tag: omap-for-v4.1/fixes-rc1~135^2~37 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d59f21bebe9d0fda34027ff1afda4f2b0d5f1869;p=pandora-kernel.git UBI: Fastmap: Fix races in ubi_wl_get_peb() ubi_wl_get_peb() has two problems, it reads the pool size and usage counters without any protection. While reading one value would be perfectly fine it reads multiple values and compares them. This is racy and can lead to incorrect pool handling. Furthermore ubi_update_fastmap() is called without wl_lock held, before incrementing the used counter it needs to be checked again. It could happen that another thread consumed all PEBs from the pool and the counter goes beyond ->size. Signed-off-by: Richard Weinberger --- Reading git-diff-tree failed