From: Roland Dreier Date: Tue, 12 Jun 2012 01:31:31 +0000 (-0700) Subject: tcm_qla2xxx: Handle malformed wwn strings properly X-Git-Tag: v3.5-rc3~17^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d4f75b567bb63b51e5ecd42af1e82d5aed5100dd;p=pandora-kernel.git tcm_qla2xxx: Handle malformed wwn strings properly If we make a variable an unsigned int and then expect it to be < 0 on a bad character, we're going to have a bad time. Fix the tcm_qla2xxx code to actually notice if hex_to_bin() returns a negative variable. This was detected by the compiler warning: scsi/qla2xxx/tcm_qla2xxx.c: In function ‘tcm_qla2xxx_npiv_extract_wwn’: scsi/qla2xxx/tcm_qla2xxx.c:148:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] Signed-off-by: Roland Dreier Signed-off-by: Nicholas Bellinger --- Reading git-diff-tree failed