From: Benoit Taine <benoit.taine@lip6.fr>
Date: Thu, 22 May 2014 14:32:30 +0000 (+0200)
Subject: nfsd: Remove assignments inside conditions
X-Git-Tag: omap-for-v3.16/fixes-against-rc1~67^2~84
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d40aa3372f90d478b6166df0321349b5aeb0aea8;p=pandora-kernel.git

nfsd: Remove assignments inside conditions

Assignments should not happen inside an if conditional, but in the line
before. This issue was reported by checkpatch.

The semantic patch that makes this change is as follows
(http://coccinelle.lip6.fr/):

// <smpl>

@@
identifier i1;
expression e1;
statement S;
@@
-if(!(i1 = e1)) S
+i1 = e1;
+if(!i1)
+S

// </smpl>

It has been tested by compilation.

Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---

Reading git-diff-tree failed