From: Linus Torvalds Date: Thu, 5 Nov 2009 18:48:30 +0000 (-0800) Subject: sgi-gru: decrapfiy options_write() function X-Git-Tag: v2.6.32-rc7~78 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d39b7dd1dcbf394a1cb897457c862dafe9a20ac5;p=pandora-kernel.git sgi-gru: decrapfiy options_write() function Not a single line of actual code in the function was really fundamentally correct. Problems ranged from lack of proper range checking, to removing the last character written (which admittedly is usually '\n'), to not accepting hex numbers even though the 'show' routine would show the data in that format. This tries to do better. Acked-by: Michael Buesch Tested-and-acked-by: Jack Steiner Cc: stable@kernel.org Cc: Jiri Kosina Cc: Michael Gilbert Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed