From: Krzysztof Kozlowski Date: Tue, 18 Mar 2014 08:13:00 +0000 (+0000) Subject: iio: cm36651: Fix i2c client leak and possible NULL pointer dereference X-Git-Tag: omap-for-v3.16/pm-signed~46^2~1^2~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d0a588a57c2b0748df8307a0865a1bbbf1624c53;p=pandora-kernel.git iio: cm36651: Fix i2c client leak and possible NULL pointer dereference During probe the driver allocates dummy I2C devices (i2c_new_dummy()) but they aren't unregistered during driver remove or probe failure. Additionally driver does not check the return value of i2c_new_dummy(). In case of error (i2c_new_device(): memory allocation failure or I2C address cannot be used) this function returns NULL which is later dereferenced by i2c_smbus_{read,write}_data() functions. Fix issues by properly checking for i2c_new_dummy() return value and unregistering I2C devices on driver remove or probe failure. Signed-off-by: Krzysztof Kozlowski Acked-by: Beomho Seo Cc: stable@vger.kernel.org Signed-off-by: Jonathan Cameron --- Reading git-diff-tree failed