From: Sathya Perla Date: Tue, 2 Aug 2011 19:57:41 +0000 (+0000) Subject: be2net: remove wrong and unnecessary calls to netif_carrier_off() X-Git-Tag: v3.2-rc1~129^2~583 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d09f698056a33c8b078497fb23e3304b6f8a908f;p=pandora-kernel.git be2net: remove wrong and unnecessary calls to netif_carrier_off() 1) In be_probe(), as soon as the MCC Q is created a gratuitous link status event is received and processed. Accordingly netif_carrier_off/on() is called. The extra netif_carrier_off() call in probe can race with this and cause wrong state. 2) be_close() need not call netif_carrier_off(). It is OK to show the actual link state even when the device is administratively down. Signed-off-by: Sathya Perla Signed-off-by: David S. Miller --- Reading git-diff-tree failed