From: H Hartley Sweeten Date: Thu, 6 Jun 2013 00:48:39 +0000 (-0700) Subject: staging: comedi: pcl730: tidy up pcl730_do_insn() X-Git-Tag: omap-for-v3.11/fixes-for-merge-window~76^2~235 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d015d96103afd9e2e7617e92a49a635dd8ee2a37;p=pandora-kernel.git staging: comedi: pcl730: tidy up pcl730_do_insn() For aesthetic reasons, rename the function. Use a local variable for the 'reg' offset that is stored in the comedi_subdevice 'private' pointer to minimize the number of casts. Also, add local variables for the 'mask' and 'bits'. The outputs only need to be updated if the 'mask' indicates that the 'bits' are changing. Move the update code into the main 'if (mask)' block. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed