From: Al Viro Date: Fri, 12 Sep 2014 19:56:04 +0000 (+0100) Subject: GFS2: fix d_splice_alias() misuses X-Git-Tag: fixes-for-v3.18-merge-window~113^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cfb2f9d5c921e38b0f12bb26fed10b877664444d;p=pandora-kernel.git GFS2: fix d_splice_alias() misuses Callers of d_splice_alias(dentry, inode) don't need iput(), neither on success nor on failure. Either the reference to inode is stored in a previously negative dentry, or it's dropped. In either case inode reference the caller used to hold is consumed. __gfs2_lookup() does iput() in case when d_splice_alias() has failed. Double iput() if we ever hit that. And gfs2_create_inode() ends up not only with double iput(), but with link count dropped to zero - on an inode it has just found in directory. Cc: stable@vger.kernel.org # v3.14+ Signed-off-by: Al Viro Signed-off-by: Steven Whitehouse --- Reading git-diff-tree failed