From: James Chapman Date: Thu, 6 Mar 2008 02:39:08 +0000 (-0800) Subject: [PPPOL2TP]: Make locking calls softirq-safe X-Git-Tag: v2.6.25-rc6~31^2~29 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cf3752e2d203bbbfc88d29e362e6938cef4339b3;p=pandora-kernel.git [PPPOL2TP]: Make locking calls softirq-safe Fix locking issues in the pppol2tp driver which can cause a kernel crash on SMP boxes. There were two problems:- 1. The driver was violating read_lock() and write_lock() scheduling rules because it wasn't using softirq-safe locks in softirq contexts. So we now consistently use the _bh variants of the lock functions. 2. The driver was calling sk_dst_get() in pppol2tp_xmit() which was taking sk_dst_lock in softirq context. We now call __sk_dst_get(). Signed-off-by: James Chapman Signed-off-by: David S. Miller --- Reading git-diff-tree failed