From: Oleg Nesterov Date: Mon, 17 Nov 2008 14:40:01 +0000 (+0100) Subject: thread_group_cputime: kill the bogus ->signal != NULL check X-Git-Tag: v2.6.29-rc1~572^2~4^6~1 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ce394471d13bf071939a9a0b48c64c297676d233;p=pandora-kernel.git thread_group_cputime: kill the bogus ->signal != NULL check Impact: simplify the code thread_group_cputime() is called by current when it must have the valid ->signal, or under ->siglock, or under tasklist_lock after the ->signal check, or the caller is wait_task_zombie() which reaps the child. In any case ->signal can't be NULL. But the point of this patch is not optimization. If it is possible to call thread_group_cputime() when ->signal == NULL we are doing something wrong, and we should not mask the problem. thread_group_cputime() fills *times and the caller will use it, if we silently use task_struct->*times* we report the wrong values. Signed-off-by: Oleg Nesterov Signed-off-by: Ingo Molnar --- Reading git-diff-tree failed