From: Florian Westphal Date: Sun, 8 Jun 2014 09:41:23 +0000 (+0200) Subject: netfilter: ctnetlink: fix refcnt leak in dying/unconfirmed list dumper X-Git-Tag: omap-for-v3.16/fixes-rc4~53^2~31^2~11 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cd5f336f1780cb20e83146cde64d3d5779e175e6;p=pandora-kernel.git netfilter: ctnetlink: fix refcnt leak in dying/unconfirmed list dumper 'last' keeps track of the ct that had its refcnt bumped during previous dump cycle. Thus it must not be overwritten until end-of-function. Another (unrelated, theoretical) issue: Don't attempt to bump refcnt of a conntrack whose reference count is already 0. Such conntrack is being destroyed right now, its memory is freed once we release the percpu dying spinlock. Fixes: b7779d06 ('netfilter: conntrack: spinlock per cpu to protect special lists.') Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- Reading git-diff-tree failed