From: Oleg Nesterov Date: Thu, 18 Jul 2013 18:47:12 +0000 (+0200) Subject: tracing: Do not (ab)use trace_seq in event_id_read() X-Git-Tag: v3.11-rc3~29^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cd458ba9d5a5592d37b5145e560071e91ea762ac;p=pandora-kernel.git tracing: Do not (ab)use trace_seq in event_id_read() event_id_read() has no reason to kmalloc "struct trace_seq" (more than PAGE_SIZE!), it can use a small buffer instead. Note: "if (*ppos) return 0" looks strange and even wrong, simple_read_from_buffer() handles ppos != 0 case corrrectly. And it seems that almost every user of trace_seq in this file should be converted too. Unless you use seq_open(), trace_seq buys nothing compared to the raw buffer, but it needs a bit more memory and code. Link: http://lkml.kernel.org/r/20130718184712.GA4786@redhat.com Signed-off-by: Oleg Nesterov Signed-off-by: Steven Rostedt --- Reading git-diff-tree failed