From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Thu, 2 Feb 2012 04:53:01 +0000 (+0000)
Subject: drivers/net/ethernet/ti: Move call to PTR_ERR after reassignment
X-Git-Tag: v3.3-rc4~34^2~53
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb0a178c787d2bdf787d56e364becdb0eb4b4fab;p=pandora-kernel.git

drivers/net/ethernet/ti: Move call to PTR_ERR after reassignment

PTR_ERR should be called before its argument is cleared.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e,e1;
constant c;
@@

*e = c
... when != e = e1
    when != &e
    when != true IS_ERR(e)
*PTR_ERR(e)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reported-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

Reading git-diff-tree failed