From: KOSAKI Motohiro Date: Tue, 15 Dec 2009 02:01:15 +0000 (-0800) Subject: Subject: Re: [PATCH] strstrip incorrectly marked __must_check X-Git-Tag: v2.6.33-rc1~111 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ca54cb8c9eb38095dc420b73c6380ce1dbeb10fa;p=pandora-kernel.git Subject: Re: [PATCH] strstrip incorrectly marked __must_check Recently, We marked strstrip() as must_check. because it was frequently misused and it should be checked. However, we found one exception. scsi/ipr.c intentionally ignore return value of strstrip. Because it wishes to keep the whitespace at the beginning. Thus we need to keep with and without checked whitespace trim function. This patch adds a new strim() and changes ipr.c to use it. [akpm@linux-foundation.org: coding-style fixes] Suggested-by: Alan Cox Signed-off-by: KOSAKI Motohiro Cc: James Bottomley Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed