From: Colin Ian King Date: Mon, 27 Jul 2015 14:23:43 +0000 (+0100) Subject: KEYS: ensure we free the assoc array edit if edit is valid X-Git-Tag: omap-for-v4.3/fixes-merge-window~173^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ca4da5dd1f99fe9c59f1709fb43e818b18ad20e0;p=pandora-kernel.git KEYS: ensure we free the assoc array edit if edit is valid __key_link_end is not freeing the associated array edit structure and this leads to a 512 byte memory leak each time an identical existing key is added with add_key(). The reason the add_key() system call returns okay is that key_create_or_update() calls __key_link_begin() before checking to see whether it can update a key directly rather than adding/replacing - which it turns out it can. Thus __key_link() is not called through __key_instantiate_and_link() and __key_link_end() must cancel the edit. CVE-2015-1333 Signed-off-by: Colin Ian King Signed-off-by: David Howells Signed-off-by: James Morris --- Reading git-diff-tree failed