From: Philipp Zabel Date: Thu, 28 May 2009 19:00:03 +0000 (+0200) Subject: regulator/max1586: fix V3 gain calculation integer overflow X-Git-Tag: v2.6.31-rc1~332^2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c8f1e5025ca2fa8e6e037451f3d271e66745a19b;p=pandora-kernel.git regulator/max1586: fix V3 gain calculation integer overflow On Thu, May 28, 2009 at 10:59 AM, Mark Brown wrote: > On Thu, May 28, 2009 at 07:15:16AM +0200, Philipp Zabel wrote: >> The V3 regulator can be configured with an external resistor >> connected to the feedback pin (R24 in the data sheet) to >> increase the voltage range. >> >> For example, hx4700 has R24 = 3.32 kOhm to achieve a maximum >> V3 voltage of 1.55 V which is needed for 624 MHz CPU frequency. >> >> Signed-off-by: Philipp Zabel > > Looks good. > > Acked-by: Mark Brown Thanks, but it turns out I hit a 32 bit integer overflow in the gain calculation. I'd like to mend that with the following patch. Now max_uV could be increased up to 4.294 V, enough to charge LiPo cells. Signed-off-by: Philipp Zabel Acked-by: Robert Jarzmik Signed-off-by: Liam Girdwood --- Reading git-diff-tree failed