From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: Fri, 12 Sep 2008 21:46:51 +0000 (-0500)
Subject: [SCSI] scsi_error: fix target reset handling
X-Git-Tag: v2.6.28-rc1~263^2~12
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c82dc88ddaf17112841dd3a6b08352968555ee08;p=pandora-kernel.git

[SCSI] scsi_error: fix target reset handling

There's a target reset bug.

This loop:

	for (id = 0; id <= shost->max_id; id++) {

Never terminates if shost->max_id is set to ~0, like aic94xx does.

It's also pretty inefficient since you mostly have compact target
numbers, but the max_id can be very high.  The best way would be to
sort the recovery list by target id and skip them if they're equal,
but even a worst case O(N^2) traversal is probably OK here, so fix it
by finding the next highest target number (assuming n+1) and
terminating when there isn't one.

Cc: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
---

Reading git-diff-tree failed