From: Peter Senna Tschudin Date: Mon, 17 Sep 2012 07:04:56 +0000 (-0300) Subject: [media] cx25821: fix error return code and clean up X-Git-Tag: omap-for-v3.8/fixes-for-merge-window-v4-signed~21^2^2~58 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c81d497284f6009a856b399e70f812671fdc7fcf;p=pandora-kernel.git [media] cx25821: fix error return code and clean up The function cx25821_sram_channel_setup_upstream_audio always return zero, so the return value is not saved any more. Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Peter Senna Tschudin Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed