From: Ralf Baechle Date: Fri, 11 Jan 2008 17:28:00 +0000 (+0000) Subject: Fix/Rewrite of the mipsnet driver] X-Git-Tag: v2.6.25-rc1~1065^2~36 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c800c5c9db9c621b2c1d70c3ae6532fafe2db69d;p=pandora-kernel.git Fix/Rewrite of the mipsnet driver] This is Thiemo's patch. ----- Forwarded message from Thiemo Seufer ----- From: Thiemo Seufer Date: Sat, 17 Nov 2007 22:29:13 +0000 To: netdev@vger.kernel.org Cc: linux-mips@linux-mips.org, ralf@linux-mips.org Subject: [PATCH, REPOST] Fix/Rewrite of the mipsnet driver Content-Type: text/plain; charset=us-ascii Hello All, currently the mipsnet driver fails after transmitting a number of packages because SKBs are allocated but never freed. I fixed that and coudn't refrain from removing the most egregious warts. - mipsnet.h folded into mipsnet.c, as it doesn't provide any useful external interface. - Free SKB after transmission. - Call free_irq in mipsnet_close, to balance the request_irq in mipsnet_open. - Removed duplicate read of rxDataCount. - Some identifiers are now less verbose. - Removed dead and/or unnecessarily complex code. - Code formatting fixes. Tested on Qemu's mipssim emulation, with this patch it can boot a Debian NFSroot. Thiemo Signed-off-by: Thiemo Seufer Signed-off-by: Jeff Garzik Signed-off-by: David S. Miller --- Reading git-diff-tree failed