From: David S. Miller <davem@sunset.davemloft.net>
Date: Sat, 28 Jul 2007 05:31:46 +0000 (-0700)
Subject: [VIDEO]: Fix OOPS in all SBUS framebuffer drivers.
X-Git-Tag: v2.6.23-rc2~155^2~5
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c7f439b99efbea74c70a5531f92566db5a6731f2;p=pandora-kernel.git

[VIDEO]: Fix OOPS in all SBUS framebuffer drivers.

All of these drivers use a silly:

struct all_info {
	struct fb_info info;
	struct foo_par par;
};

struct all_info *all = kzalloc(sizeof(*all), GFP_KERNEL);
all->info.par = &all->par;

etc. etc. code sequence, basically replicating the provided
framebuffer_alloc()/framebuffer_release(), and doing it badly.

Not only is this massive code duplication, it also caused a
bug in that we weren't setting the fb_info->device pointer
which results in an OOPS when fb_is_primary_device() runs.

Fix all of this by using framebuffer_{alloc,release}() and
passing in "&of_device->dev" as the device pointer.

Signed-off-by: David S. Miller <davem@davemloft.net>
---

Reading git-diff-tree failed