From: Roland Dreier Date: Wed, 31 Oct 2012 16:16:44 +0000 (-0700) Subject: target: Don't return success from module_init() if setup fails X-Git-Tag: v3.2.34~35 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c7685e47cf98dbaeaf523b7c235bf251bba1354f;p=pandora-kernel.git target: Don't return success from module_init() if setup fails commit 0d0f9dfb31e0a6c92063e235417b42df185b3275 upstream. If the call to core_dev_release_virtual_lun0() fails, then nothing sets ret to anything other than 0, so even though everything is torn down and freed, target_core_init_configfs() will seem to succeed and the module will be loaded. Fix this by passing the return value on up the chain. Signed-off-by: Roland Dreier Signed-off-by: Nicholas Bellinger Signed-off-by: Ben Hutchings --- Reading git-diff-tree failed