From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 5 Feb 2014 13:29:21 +0000 (+0300)
Subject: tg3: cleanup an error path in tg3_phy_reset_5703_4_5()
X-Git-Tag: v3.14-rc3~36^2~41
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c6e27f2f3cf2631aae6f1f6fae1a7ab083fdb024;p=pandora-kernel.git

tg3: cleanup an error path in tg3_phy_reset_5703_4_5()

In the original code, if tg3_readphy() fails then it does an unnecessary
check to verify "err" is still zero and then returns -EBUSY.

My static checker complains about the unnecessary "if (!err)" check and
anyway it is better to propagate the -EBUSY error code from
tg3_readphy() instead of hard coding it here.  And really the original
code is confusing to look at.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

Reading git-diff-tree failed