From: Roel Kluin <12o3l@tiscali.nl> Date: Wed, 5 Dec 2007 19:57:30 +0000 (-0800) Subject: e1000: fix memcpy in e1000_get_strings X-Git-Tag: v2.6.24-rc5~38 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c32bc6e9b0778c891f7f3b97cd05c8cdf98b6721;p=pandora-kernel.git e1000: fix memcpy in e1000_get_strings drivers/net/e1000/e1000_ethtool.c:113: #define E1000_TEST_LEN sizeof(e1000_gstrings_test) / ETH_GSTRING_LEN drivers/net/e1000e/ethtool.c:106: #define E1000_TEST_LEN sizeof(e1000_gstrings_test) / ETH_GSTRING_LEN E1000_TEST_LEN*ETH_GSTRING_LEN will expand to sizeof(e1000_gstrings_test) / (ETH_GSTRING_LEN * ETH_GSTRING_LEN) A lack of parentheses around defines causes unexpected results due to operator precedences. Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Signed-off-by: Auke Kok Signed-off-by: Jeff Garzik --- Reading git-diff-tree failed