From: Anders Larsen Date: Sun, 18 Aug 2013 09:54:40 +0000 (+0200) Subject: pch_gbe: ethtool cannot change parameters when link is down X-Git-Tag: v3.12-rc1~132^2~255 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c196ce05cfdb7b5a8af12a3096fac9e880d59617;p=pandora-kernel.git pch_gbe: ethtool cannot change parameters when link is down When attempting to change e.g. the advertising mask when the link is down ecmd->speed is -1 causing mii_ethtool_sset() to bail out. This bug bit when connecting to a gigabit switch through a 4-pin (industrial) cable, since link negotiation would not complete (both endpoints claimed to be gigabit-capable, but this is not possible with only 4 pins). Any attempt to fix this by setting autonegation to not offer 1000Mbps failed as the setting would not be accepted while the link was still down... Set ecmd->speed to SPEED_1000 to satisfy mii_ethtool_sset() (the actual value of ecmd->speed doesn't matter as long as it is valid, since a re-negotation is forced afterwards). Signed-off-by: Anders Larsen Signed-off-by: David S. Miller --- Reading git-diff-tree failed