From: J. Bruce Fields Date: Fri, 16 Feb 2007 09:28:36 +0000 (-0800) Subject: [PATCH] knfsd: nfsd4: acls: avoid unnecessary denies X-Git-Tag: v2.6.21-rc1~101 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bec50c47aaf6f1f9247f1860547ab394a0802a4c;p=pandora-kernel.git [PATCH] knfsd: nfsd4: acls: avoid unnecessary denies We're inserting deny's between some ACEs in order to enforce posix draft acl semantics which prevent permissions from accumulating across entries in an acl. That's fine, but we're doing that by inserting a deny after *every* allow, which is overkill. We shouldn't be adding them in places where they actually make no difference. Also replaced some helper functions for creating acl entries; I prefer just assigning directly to the struct fields--it takes a few more lines, but the field names provide some documentation that I think makes the result easier understand. Signed-off-by: J. Bruce Fields Signed-off-by: Neil Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- Reading git-diff-tree failed