From: Santosh Nayak Date: Sun, 26 Feb 2012 13:33:30 +0000 (+0530) Subject: [SCSI] pm8001: Fix bogus interrupt state flag issue. X-Git-Tag: v3.4-rc1~145^2~10 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bdaefbf580cd200ae3230b6aacd1f4f2dadb18e3;p=pandora-kernel.git [SCSI] pm8001: Fix bogus interrupt state flag issue. Static checker is giving following warning: " error: calling 'spin_unlock_irqrestore()' with bogus flags" The code flow is as shown below: process_oq() --> process_one_iomb --> mpi_sata_completion In 'mpi_sata_completion' the first call for 'spin_unlock_irqrestore()' is with flags=0, which is as good as 'spin_unlock_irq()' ( unconditional interrupt enabling). So for better performance 'spin_unlock_irqrestore()' can be replaced with 'spin_unlock_irq()' and 'spin_lock_irqsave()' can be replaced by 'spin_lock_irq()'. Signed-off-by: Santosh Nayak Acked-by: Jack Wang Signed-off-by: James Bottomley --- Reading git-diff-tree failed