From: Tony Luck Date: Mon, 18 May 2015 20:39:06 +0000 (-0300) Subject: sb_edac: Fix a typo and a thinko in address handling for Haswell X-Git-Tag: omap-for-v4.2/fixes-rc1^2~110^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bb89e7141a4e5690a046d3bdfa57b8521aab64b0;p=pandora-kernel.git sb_edac: Fix a typo and a thinko in address handling for Haswell typo: "a7mode" chooses whether to use bits {8, 7, 9} or {8, 7, 6} in the algorithm to spread access between memory resources. But the non-a7mode path was incorrectly using GET_BITFIELD(addr, 7, 9) and so picking bits {9, 8, 7} thinko: BIT(1) of the dram_rule registers chooses whether to just use the {8, 7, 6} (or {8, 7, 9}) bits mentioned above as they are, or to XOR them with bits {18, 17, 16} but the code inverted the test. We need the additional XOR when dram_rule{1} == 0. Signed-off-by: Tony Luck Acked-by: Aristeu Rozanski Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed