From: John Linville Date: Mon, 10 Aug 2015 16:05:39 +0000 (-0400) Subject: mwl8k: refactor some conditionals for clarity X-Git-Tag: omap-for-v4.3/fixes-rc1~110^2~124^2~6 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bafc6e4cd897ef14015d8d32a04ee9bfa8d91370;p=pandora-kernel.git mwl8k: refactor some conditionals for clarity CC [M] drivers/net/wireless/mwl8k.o drivers/net/wireless/mwl8k.c: In function ‘mwl8k_bss_info_changed’: drivers/net/wireless/mwl8k.c:3290:2: warning: ‘ap_mcs_rates’ may be used uninitialized in this function [-Wmaybe-uninitialized] memcpy(cmd->mcs_set, mcs_rates, 16); ^ drivers/net/wireless/mwl8k.c:4987:5: note: ‘ap_mcs_rates’ was declared here u8 ap_mcs_rates[16]; ^ The warning was bogus. But the conditionals were rather complicated, with multiple redundant checks. This consolidates the checking and makes it more readable IMHO. Signed-off-by: John W. Linville Signed-off-by: Kalle Valo --- Reading git-diff-tree failed