From: Trent Piepho Date: Mon, 22 Sep 2008 17:03:56 +0000 (-0700) Subject: gianfar: Fix error in mdio reset timeout X-Git-Tag: v2.6.28-rc1~717^2~185 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=baac03d9bb7b8aa3c33a2dbf5f459ea6ce8abaf4;p=pandora-kernel.git gianfar: Fix error in mdio reset timeout The loop with the timeout used "while (... && timeout--)", which means than when the timeout occurs, "timeout" will be -1 after the loop has exited. The code that checks if the looped exited because of a timeout used "if (timeout <= 0)". Seems ok, except timeout is unsigned, and (unsigned)-1 isn't less than zero! Using "--timeout" in the loop fixes this problem, as now "timeout" will be 0 when the loop times out. This also fixes a bug in the existing code, where it will erroneously think a timeout occurred if the condition the loop was waiting for is satisfied on the final iteration before a timeout. Signed-off-by: Trent Piepho Acked-by: Andy Fleming Signed-off-by: Jeff Garzik --- Reading git-diff-tree failed