From: H Hartley Sweeten Date: Mon, 20 Oct 2014 18:34:19 +0000 (-0700) Subject: staging: comedi: addi_apci_3120: remove analog output reset X-Git-Tag: omap-for-v3.19/fixes-rc1~73^2~807 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b9ae204658334a4a34a60dd2de6ba0415b3a79d4;p=pandora-kernel.git staging: comedi: addi_apci_3120: remove analog output reset The apci3120_reset() function is called at the end of the (*auto_attach) and with the (*detach) is called to unload the driver. Part of this function resets all the analog output channels to 0V. There are two problems with this. 1) Only the APCI-3120 has analog outputs, the APCI-3001 does not. 2) The DA_READY bit in the status register needs to be checked before each write to update the analog outputs. It's unknown what the DA_READY bit does on the APCI-3001 board. Just remove the analog output reset to avoid any problems. Also, remove the unnecessary udelay() in apci3120_reset(). Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed