From: Dave Chinner <dchinner@redhat.com>
Date: Wed, 28 Nov 2012 02:01:02 +0000 (+1100)
Subject: xfs: fix stray dquot unlock when reclaiming dquots
X-Git-Tag: omap-for-v3.8/fixes-for-merge-window-v4-signed~55^2~1
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b870553cdecb26d5291af09602352b763e323df2;p=pandora-kernel.git

xfs: fix stray dquot unlock when reclaiming dquots

When we fail to get a dquot lock during reclaim, we jump to an error
handler that unlocks the dquot. This is wrong as we didn't lock the
dquot, and unlocking it means who-ever is holding the lock has had
it silently taken away, and hence it results in a lock imbalance.

Found by inspection while modifying the code for the numa-lru
patchset. This fixes a random hang I've been seeing on xfstest 232
for the past several months.

cc: <stable@vger.kernel.org>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
---

Reading git-diff-tree failed