From: Paul Gortmaker Date: Mon, 15 Jun 2015 22:12:47 +0000 (-0700) Subject: drivers/leds: don't use module_init in non-modular leds-cobalt-raq.c X-Git-Tag: omap-for-v4.2/fixes-rc1^2~51^2~5 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b83fae0c0c5ea97aad4f762dae99342f94523f42;p=pandora-kernel.git drivers/leds: don't use module_init in non-modular leds-cobalt-raq.c This file is built for a bool Kconfig variable, and hence this code is either present or absent. It currently can never be modular, so using module_init as an alias for __initcall can be somewhat misleading. Fix this up now, so that we can relocate module_init from init.h into module.h in the future. If we don't do this, we'd have to add module.h to obviously non-modular code, and that would be a worse thing. Note that direct use of __initcall is discouraged, vs. one of the priority categorized subgroups. As __initcall gets mapped onto device_initcall, our use of device_initcall directly in this change means that the runtime impact is zero -- it will remain at level 6 in initcall ordering. And since it can't be modular, we remove all the __exitcall stuff related to module_exit() -- it is dead code that won't ever be executed. Cc: Richard Purdie Cc: linux-leds@vger.kernel.org Signed-off-by: Paul Gortmaker Acked-by: Jacek Anaszewski Signed-off-by: Bryan Wu --- Reading git-diff-tree failed