From: Vladimir Zapolskiy Date: Mon, 18 May 2015 17:11:46 +0000 (+0300) Subject: char: misc: restore MISC_DYNAMIC_MINOR on device_create() failure X-Git-Tag: omap-for-v4.2/fixes-rc1^2~94^2~38 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b575f7124ab33b2a4239613bcc870380308fe0a7;p=pandora-kernel.git char: misc: restore MISC_DYNAMIC_MINOR on device_create() failure On attempt to register a dynamic minor misc device its minor number is updated to a virtual minor number prior to device_create() call, however on error path misc->minor == MISC_DYNAMIC_MINOR is not restored. Following the rule of thumb that a function returning an error must not change the state of the caller, assign MISC_DYNAMIC_MINOR back. The problem is met in a sutuation, when subsys_initcall(misc_init) is not yet called and misc_class is not created, but misc_register() modifies statically defined ".minor = MISC_DYNAMIC_MINOR", therefore implicitly changing the client's logic on next attempt (e.g. retrying from deferred list) to register a misc device, whose minor number is converted from dynamic to some unknown static one. Signed-off-by: Vladimir Zapolskiy Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed