From: Dan Carpenter Date: Tue, 21 Jan 2014 07:00:10 +0000 (+0300) Subject: [SCSI] qla2xxx: fix error handling of qla2x00_mem_alloc() X-Git-Tag: v3.15-rc1~136^2~166 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b2a72ec32d0f499aaadf41264232517a12326df0;p=pandora-kernel.git [SCSI] qla2xxx: fix error handling of qla2x00_mem_alloc() qla2x00_mem_alloc() returns 1 on success and -ENOMEM on failure. On the one hand the caller assumes non-zero is success but on the other hand the caller also assumes that it returns an error code. I've fixed it to return zero on success and a negative error code on failure. This matches the documentation as well. [jejb: checkpatch fix] Fixes: e315cd28b9ef ('[SCSI] qla2xxx: Code changes for qla data structure refactoring') Signed-off-by: Dan Carpenter Acked-by: Saurav Kashyap Signed-off-by: James Bottomley --- Reading git-diff-tree failed