From: Daniel Vetter Date: Thu, 19 Sep 2013 12:00:11 +0000 (+0200) Subject: drm/i915: Use unsigned for overflow checks in execbuf X-Git-Tag: v3.13-rc1~76^2~80^2~89 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b205ca572159ab9a617fc96e4659bc138064ca8e;p=pandora-kernel.git drm/i915: Use unsigned for overflow checks in execbuf There's actually no real risk since we already check for stricter constraints earlier (using UINT_MAX / sizeof (struct drm_i915_gem_exec_object2) as the limit). But in eb_create we use signed integers, which steals a factor of 2. Luckily struct drm_i915_gem_exec_object2 for this to not matter. Still, be consistent and use unsigned integers. Similar use unsinged integers when checking for overflows in the relocation entry processing. I've also added a new subtests to igt/gem_reloc_overflow to also test for overflowing args->buffer_count values. v2: Give the variables again tighter scope to make it clear that the computation is purely local and doesn't leak out to the 2nd block. Requested by Chris Wilson. Cc: Chris Wilson Reviewed-by: Chris Wilson Signed-off-by: Daniel Vetter --- Reading git-diff-tree failed