From: Oleg Nesterov Date: Wed, 27 Apr 2011 19:56:14 +0000 (+0200) Subject: signal: do_sigtimedwait() needs retarget_shared_pending() X-Git-Tag: v3.0-rc1~382^2~6 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b182801ab35f7a0afb3cdf8ba5df464d04206b46;p=pandora-kernel.git signal: do_sigtimedwait() needs retarget_shared_pending() do_sigtimedwait() changes current->blocked and thus it needs set_current_blocked()->retarget_shared_pending(). We could use set_current_blocked() directly. It is fine to change ->real_blocked from all-zeroes to ->blocked and vice versa lockless, but this is not immediately clear, looks racy, and needs a huge comment to explain why this is correct. To keep the things simple this patch adds the new static helper, __set_task_blocked() which should be called with ->siglock held. This way we can change both ->real_blocked and ->blocked atomically under ->siglock as the current code does. This is more understandable. Signed-off-by: Oleg Nesterov Acked-by: Tejun Heo Reviewed-by: Matt Fleming --- Reading git-diff-tree failed