From: Ian Abbott Date: Fri, 12 Jun 2015 15:37:41 +0000 (+0100) Subject: staging: comedi: cb_pcimdas: fix handlers for DI and DO subdevices X-Git-Tag: omap-for-v4.3/legacy-v2-signed~121^2~223 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b08ad6657aacf9b5d7c4b22de2ba891b152d0528;p=pandora-kernel.git staging: comedi: cb_pcimdas: fix handlers for DI and DO subdevices Normally, low-level Comedi drivers set an `insn_bits` handler for digital input (DI), digital output (DO) and digital input/output (DIO) subdevice types to handle normal reading and writing of digital channels. The "cb_pcimdas" driver currently has an `insn_read` handler for the DI subdevice and an `insn_write` handler for the DO subdevice. However, the actual handler functions `cb_pcimdas_di_insn_read()` and `cb_pcimdas_do_insn_write()` are written to behave like `insn_bits` handlers. Something's wrong there! To fix it, set the functions as `insn_bits` handlers and rename them for consistency. Fixes: e56d03dee14a ("staging: comedi: cb_pcimdas: add main connector digital input/output") Signed-off-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed