From: Mitchell Blank Jr <mitch@sfgoth.com>
Date: Tue, 11 Apr 2006 05:54:08 +0000 (-0700)
Subject: [PATCH] select: don't overflow if (SELECT_STACK_ALLOC % sizeof(long) != 0)
X-Git-Tag: v2.6.17-rc2~197
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b04eb6aa08ecc3e24df2f78ebc486011ebd74feb;p=pandora-kernel.git

[PATCH] select: don't overflow if (SELECT_STACK_ALLOC % sizeof(long) != 0)

If SELECT_STACK_ALLOC is not a multiple of sizeof(long) then stack_fds[]
would be shorter than SELECT_STACK_ALLOC bytes and could overflow later in
the function.  Fixed by simply rearranging the test later to work on
sizeof(stack_fds) Currently SELECT_STACK_ALLOC is 256 so this doesn't
happen, but it's nasty to have things like this hidden in the code.  What
if later someone decides to change SELECT_STACK_ALLOC to 300?

Signed-off-by: Mitchell Blank Jr <mitch@sfgoth.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

Reading git-diff-tree failed