From: Fabio Estevam Date: Mon, 22 Sep 2014 20:55:29 +0000 (-0300) Subject: fec: Remove fec_enet_select_queue() X-Git-Tag: fixes-against-v3.18-rc2~144^2~143 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aebac744932439b5f869869f07f406a9cced465d;p=pandora-kernel.git fec: Remove fec_enet_select_queue() Sparse complains about fec_enet_select_queue() not being static. Feedback from David Miller [1] was to remove this function instead of making it static: "Please just delete this function. It's overriding code which does exactly the same thing. Actually, more precisely, this code is duplicating code in a way that bypasses many core facilitites of the networking. For example, this override means that socket based flow steering, XPS, etc. are all not happening on these devices. Without ->ndo_select_queue(), the flow dissector does __netdev_pick_tx which is exactly what you want to happen." [1] http://www.spinics.net/lists/netdev/msg297653.html Signed-off-by: Fabio Estevam Signed-off-by: David S. Miller --- Reading git-diff-tree failed